`make binary-dist` is broken

If we run

./boot
./configure
make
make binary-dist

We are soon greeted with the following error

cd bindistprep && "/bin/tar" hcf - -T ../bindist-list.uniq | /usr/bin/xz -c > ../bindistprep/ghc-8.3.20171025-x86_64-unknown-linux.tar.xz
/bin/tar: ghc-8.3.20171025/testsuite/utils/check-api-annotations/dist-install/build/.depend.c_asm: Cannot stat: No such file or directory
/bin/tar: ghc-8.3.20171025/testsuite/utils/check-api-annotations/dist-install/build/.depend.haskell: Cannot stat: No such file or directory
/bin/tar: ghc-8.3.20171025/testsuite/utils/check-api-annotations/dist-install/package-data.mk: Cannot stat: No such file or directory
/bin/tar: ghc-8.3.20171025/testsuite/utils/check-api-annotations/ghc.mk: Cannot stat: No such file or directory
/bin/tar: ghc-8.3.20171025/testsuite/utils/check-ppr/dist-install/build/.depend.c_asm: Cannot stat: No such file or directory
/bin/tar: ghc-8.3.20171025/testsuite/utils/check-ppr/dist-install/build/.depend.haskell: Cannot stat: No such file or directory
/bin/tar: ghc-8.3.20171025/testsuite/utils/check-ppr/dist-install/package-data.mk: Cannot stat: No such file or directory
/bin/tar: ghc-8.3.20171025/testsuite/utils/check-ppr/ghc.mk: Cannot stat: No such file or directory
/bin/tar: Exiting with failure status due to previous errors
mv bindistprep/*.tar.xz "."

I suspect https://github.com/ghc/ghc/commit/1e9f90af7311c33de0f7f5b7dba594725596d675 is to blame: bindist was not updated.

A temporary work around I'm using is

+    $(filter-out testsuite/utils/check-ppr/% testsuite/utils/check-api-annotations/% %/project.mk mk/config.mk %/mk/install.mk,$(MAKEFILE_LIST)) \

in top level ghc.mk in bindist-list eval section.

I have reported this in #ghc to Ben but I am creating this ticket such that we can track the progress.

Trac metadata

Trac field	Value
Version	8.3
Type	Bug
TypeOfFailure	OtherFailure
Priority	normal
Resolution	Unresolved
Component	Build System
Test case
Differential revisions
BlockedBy
Related
Blocking
CC
Operating system
Architecture

mentioned in issue #13897 (closed)

changed weight to 5

added Tbug Trac import labels

Just ran the same command on a610c215 and ended up with a different error:

cd bindistprep && "/bin/tar" hcf - -T ../bindist-list.uniq | /bin/xz -c > ../bindistprep/ghc-8.5.20180612-x86_64-unknown-linux.tar.xz
/bin/tar: ghc-8.5.20180612/libraries/libiserv/LICENSE : stat impossible: No such file or directory

The patch originally introducing this issue, 1e9f90af, was reverted in d9b6015d. This ticket should have been closed at this point.

Unfortunately it does look like there is now another related issue due to the recent libiserv renaming, which inexplicably dropped the license file, which is expected by the bindist script. This should be fixed by D4844.

Trac metadata

Trac field	Value
Differential revisions	- → D4844

mentioned in commit 908edbfb

closed

changed milestone to %8.6.1

This should now be fixed.

Trac metadata

Trac field	Value
Resolution	Unresolved → ResolvedFixed

The new Hadrian build system has been merged. Relabeling the tickets concerning the legacy make build system to prevent confusion.

Trac metadata

Trac field	Value
Component	Build System → Build System (make)

added Pnormal label