Make the interface of traceTc and traceRn the same

It always seemed strange to me that the interfaces for traceTc and traceRn were different.

traceTc :: String -> SDoc -> TcM ()
traceRn :: SDoc -> RnM ()

I personally prefer using the traceTc interface and have to look up each time which function uses which interface. It seems beneficial but annoying to make traceRn have the same interface to improve usability slightly.

Are there any objections if someone was to do this?

Trac metadata

Trac field	Value
Version	8.0.1
Type	Task
TypeOfFailure	OtherFailure
Priority	lowest
Resolution	Unresolved
Component	Compiler
Test case
Differential revisions
BlockedBy
Related
Blocking
CC
Operating system
Architecture

changed weight to 0

added Ttask Trac import labels

I'm all for it. Historical accident. I much prefer the traceTc interface.

Modifying the traceRn interface to the traceTc interface causes 3 of the performance tests to fail due to the strings being floated to the top level (by -ffull-laziness) and hence allocated. Previously these strings were not allocated as there is a rule which optimises text "abc" to ptext (Ptr p).

Here is the diff where I tried various things to fix this: https://phabricator.haskell.org/D2586

Thanks for the diff. Surely whatever problem traceRn has, traceTc has too? Adding a rule for both cases seems useful.

The rule doesn't seem to fix anything. I can't reproduce the failing tests on my machine which makes development slow. You are right though that there is also this problem with traceTc.

mentioned in commit 925d178e

closed

changed milestone to %8.2.1

Trac metadata

Trac field	Value
Resolution	Unresolved → ResolvedFixed

added Plow label