quoting and Template Haskell handling for prim and javascript foreign imports broken

In GHC 7.10.1, Template Haskell support was added for all calling conventions. Unfortunately a few cases are unhandled, which makes the TH code treat the prim and javascript calling conventions as if they were C calling conventions, adding the static keyword and running them through parseCImport.

This is particularly bad for javascript imports, since most JS imports aren't valid C imports, so they get rejected.

I'm testing a fix for this that I'll submit later today. I hope this is in time for 7.10.2

Trac metadata

Trac field	Value
Version	7.10.1
Type	Bug
TypeOfFailure	OtherFailure
Priority	normal
Resolution	Unresolved
Component	Compiler
Test case
Differential revisions
BlockedBy
Related
Blocking
CC
Operating system
Architecture

changed milestone to %7.10.2

changed weight to 5

added Tbug Trac import labels

Trac metadata

Trac field	Value
Differential revisions	→ D1070

changed weight to 10

Trac metadata

Trac field	Value
Priority	normal → highest

Attached file trac-10638-710.patch (download).

diff from phabricator backported to 7.10 branch

The backported patch has been merged to ghc-7.10 as 98587f0c.

mentioned in commit 4cd008b6

closed

Trac metadata

Trac field	Value
Resolution	Unresolved → ResolvedFixed

Is there a regression test for this?

Simon

Yes it's part of D1070, but it's not backported to the 7.10 branch.

Trac metadata

Trac field	Value
Test case	- → th/T10638

added Phighest label