msys native python testsuite support doesn't work in some situations
On a vanilla Windows 8.1, msys2 GHC installation with only msys python installed, the testsuite driver is broken. I know of one other person whose testsuite is also not working. The usual error message is:
cd ./typecheck/should_compile && "C:/msys64/home/ezy.exe" -c tc055.hs -fforce-recomp -dcore-lint -dcmm-lib -rtsopts -fno-warn-tabs -fno-ghci-history -fno-warnrr 2>&1
'..\timeout\install-inplace\bin\timeout.exe" "300" "cexternal command,
operable program or batch file.
Compile failed (status 256) errors were:I have diagnosed the problem to the fact that we are passing a complex command string to cmd with adequately quoting it. In particular, when I inspect the command line that Python is attempting to invoke, it looks something like this:
cmd \c 'timeout.exe 300 "cd . && "inplace/ghc-stage2" -c blah blah"'Notice, in particular, that the quoted GHC executable was not inside the timeout invocation is not double-quoted, so cmd does NOT parse the command the way you want it to.
Curiously enough, when I remove this fix (introduced by commit 101c62e26286353dd3fac1ef54323529b64c9902), the msys Python runner works fine. So I don't even know what this commit was intended to fix; it seems to have done more harm than good
Here are some details about my configuration:
ezyang@cutlass MSYS ~/ghc-validate/testsuite
$ python2 --version
Python 2.7.9
ezyang@cutlass MSYS ~/ghc-validate/testsuite
$ bash --version
GNU bash, version 4.3.33(3)-release (x86_64-pc-msys)
Copyright (C) 2013 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
Trac metadata
| Trac field | Value |
|---|---|
| Version | 7.11 |
| Type | Bug |
| TypeOfFailure | OtherFailure |
| Priority | high |
| Resolution | Unresolved |
| Component | Test Suite |
| Test case | |
| Differential revisions | |
| BlockedBy | |
| Related | |
| Blocking | |
| CC | |
| Operating system | |
| Architecture |
Activity
mentioned in issue #9626 (closed)
added Tbug Trac import testsuite labels
I partially understand what's going on.
In commit 5258566e I simplified the string formatting and program path quoting in the testsuite driver. One change is that the path of the GHC executable is now double quoted instead of single quoted.
(This is done before it reaches the Python part of the testsuite driver, in
mk/test.mk. I just noticed an unrelated bug here with empty program paths, which I'll fix shortly).This change is apparently not compatible with the escaping that
passThroughCmddoes. Before (good):>> passThroughCmd(["timeout", "300", "cd . && 'inplace/ghc-stage2' -c foo"])[2] timeout "300" "cd . && 'inplace/ghc-stage2' -c foo"After (bad):
>> passThroughCmd(['timeout', '300', 'cd . && "inplace/ghc-stage2" -c foo'])[2] timeout "300" "cd . && "inplace/ghc-stage2" -c foo"If everything works after removing the function
passThroughCmdintroduced in 101c62e2, I suggest doing that.# When running under native msys Python, any invocations of non-msys binaries, # including timeout.exe, will have their arguments munged according to some # heuristics
Maybe the heuristics changed in a new version of msys, or the change from single quoting to double quoting somehow effects it?.
Otherwise changing
'"%s"'to"'%s'"might work.mentioned in issue #10449 (closed)
If old msys is doing some terrible quoting, but new msys does not, can we just error if someone tries to use an old msys? I looked at the changelog for msys but didn't see anything that indicated that the heuristic changed. I see no documentation anywhere on the net about the heuristic. This makes me very grumpy.
Trac metadata
Trac field Value Differential revisions → D952 mentioned in commit bb996712
changed milestone to %7.10.2
Please merge to ghc-7.10, as that branch also contains the patch that changed the quoting (dde3a237, #10164 (closed)).
Trac metadata
Trac field Value Version 7.11 → 7.10.1 added Phigh label
