Add support for "foo"## literals to MagicHash
I'm working on a high-performance library for building up buffers of data. Appending ByteStrings works pretty well, but, for bytestring literals, it's faster to avoid the CAF (and it's associated tag check + indirect jump) entirely and append a zero-terminate MagicHash string literal via Addr#.
Then I discovered that it's 30% faster if you can avoid the strlen with an explicit length. See this benchmark: https://github.com/chadaustin/buffer-builder/blob/ac662962d6d3c21f206ab8e8121323b9f18677fa/bench/Bench.hs#L42
That API is not very pleasant, of course. :)
Thus, here is a feature request:
It would be great if "foo"## produced (# Int#, Addr# #), where the Int# is the length of the buffer in bytes.
The compiler could enforce that the literal only contains 8-bit values.
Trac metadata
| Trac field | Value |
|---|---|
| Version | 7.8.4 |
| Type | FeatureRequest |
| TypeOfFailure | OtherFailure |
| Priority | normal |
| Resolution | Unresolved |
| Component | Compiler |
| Test case | |
| Differential revisions | |
| BlockedBy | |
| Related | |
| Blocking | |
| CC | |
| Operating system | |
| Architecture |
Relates to
Activity
mentioned in issue #5218 (closed)
added Tfeature request Trac import labels
Is this the same as #5218 (closed)? Which needs love.
Simon
Hi! I don't think it's exactly the same as #5218 (closed) since I don't specifically need ByteStrings here, just a quick Int#, Addr# pair. But #5218 (closed) could definitely be implemented on top of a mechanism that desugars to this (e.g. unpackCStringLen "my literal"##).
If you'd like to merge the bugs, that's fine with me, as long as there's a way to get at some machinery to generate string length Int#s at compile time. :)
I think we should indeed treat this as a duplicate of #5218 (closed) as the answer proposed in ticket:10064#comment:95901 is precisely that which is being implemented in D2443.
Trac metadata
Trac field Value Resolution Unresolved → ResolvedDuplicate Related - → #5218 (closed) added Pnormal label
